Added Maven native implementation using flexpack by agrasth · Pull Request #3081 · jfrog/jfrog-cli

agrasth · 2025-09-11T22:48:19Z

All tests have passed. If this feature is not already covered by the tests, new tests have been added.
The pull request is targeting the dev branch.
The code has been validated to compile successfully by running go vet ./....
The code has been formatted properly using go fmt ./....

Add FlexPack Maven Support to JFrog CLI

Summary

Implements native FlexPack Maven support in JFrog CLI, leveraging the FlexPack implementation from build-info-go to provide enhanced build info collection and artifact management for Maven projects.

Changes Made

FlexPack Integration

Added FlexPack Maven test coverage in maven_test.go
Integrated with build-info-go FlexPack implementation for native Maven support
Added tests for FlexPack build info collection and artifact deployment
Implemented build properties validation for FlexPack-deployed artifacts

Test Enhancements

TestMavenBuildWithFlexPack: Validates FlexPack artifact deployment
TestMavenBuildWithFlexPackBuildInfo: Tests build info collection with dependency tracking
TestMavenFlexPackBuildProperties: Verifies build properties are correctly set on artifacts
Added comprehensive dependency validation (checksums, scopes, types)

Dependencies

Utilizes FlexPack implementation from build-info-go repository
Requires JFROG_RUN_NATIVE=true environment variable for FlexPack execution

Files Modified

jfrog-cli/maven_test.go - Added FlexPack test coverage and fixed linting issues

naveenku-jfrog · 2025-09-16T09:18:43Z

utils/buildinfo/buildinfo.go

+	buildInstance, err := buildInfoService.GetOrCreateBuildWithProject(
+		buildInfo.Name,
+		buildInfo.Number,
+		"", // project key - can be empty for now


Shouldn't we pass projectKey that is available with buildInfoService?

Thanks! will add this.

naveenku-jfrog · 2025-09-16T09:22:31Z

utils/buildinfo/buildinfo.go

+	// Get deployment repository from configuration
+	deployRepo := getDeploymentRepoFromConfig(workingDir)
+	if deployRepo == "" {
+		deployRepo = "maven-flexpack-local" // fallback


We should use Const for storing hardcoded strings.

naveenku-jfrog · 2025-09-16T09:24:24Z

utils/buildinfo/buildinfo.go

+	// Also check for POM file (deployed by Maven from project root)
+	pomPatterns := []string{
+		"pom.xml", // The original POM file that Maven deployed
+	}


Why only file inside slice? Are we expecting more files to be added inside it? If no, then no need of slice.

utils/buildinfo/buildinfo.go

- Move FlexPack command handling from main.go to jfrog-cli-artifactory - Remove business logic functions (runNativeImplementation, RunActions, etc.) - Simplify main.go to focus on CLI routing only - Keep minimal import for GetJfrogCliArtifactoryApp compatibility - Successfully builds and runs basic CLI functionality This follows the established pattern where: - jfrog-cli: Command routing and CLI setup - jfrog-cli-artifactory: Business logic for Artifactory commands - build-info-go: Core FlexPack implementations

- Remove artifact verification from TestMavenBuildWithFlexPack and TestMavenBuildWithFlexPackBuildInfo - FlexPack with 'install' correctly only installs to local repository - Traditional Maven Build Info Extractor auto-deploys during install, but FlexPack follows pure Maven behavior - TestMavenFlexPackBuildProperties still uses 'deploy' and expects artifacts (correct)

…nstall - FlexPack follows standard Maven behavior where 'install' only installs to local repository - Traditional Maven Build Info Extractor auto-deploys during install (non-standard) - Updated test to not expect artifacts in build info when using 'install' with FlexPack - This aligns with the correct Maven semantics that FlexPack implements

- FlexPack uses pure Maven which requires proper <distributionManagement> in POM - Traditional Maven Build Info Extractor bypasses this requirement - Test POM doesn't have deployment configuration, causing 'mvn deploy' to fail - This is expected behavior for FlexPack - it follows standard Maven semantics

- Resolved conflicts in go.mod and go.sum - Kept local development paths for build-info-go and jfrog-cli-artifactory - Updated to latest upstream dependencies

- Removed obsolete FlexPack comments that are no longer needed - Removed duplicate CommandNotFound handler - FlexPack is now properly integrated through buildtools CLI

- Added log.Debug message when JFROG_RUN_NATIVE is detected - This provides better visibility into when FlexPack is being used - Consistent with the logging in jfrog-cli-artifactory/artifactory/commands/mvn/utils.go

- Re-added the log.Debug message that was accidentally removed - This debug message helps track when JFROG_RUN_NATIVE routing is used

- Removed duplicate import of jfrog-cli-core/v2/utils/log - The file already uses jfrog-client-go/utils/log package - This fixes the build error with redeclared log package

github-actions · 2025-10-06T11:27:55Z

🐸 JFrog Frogbot

agrasth had a problem deploying to frogbot September 11, 2025 22:48 — with GitHub Actions Failure

agrasth added the improvement Automatically generated release notes label Sep 11, 2025

agrasth force-pushed the mavenFlexpack branch from a1ecb5c to 2920eff Compare September 11, 2025 22:53

agrasth had a problem deploying to frogbot September 11, 2025 22:53 — with GitHub Actions Failure

agrasth force-pushed the mavenFlexpack branch from 2920eff to c02dc3c Compare September 11, 2025 23:19

agrasth had a problem deploying to frogbot September 11, 2025 23:19 — with GitHub Actions Failure

agrasth force-pushed the mavenFlexpack branch from c02dc3c to 15dabf6 Compare September 12, 2025 05:48

agrasth had a problem deploying to frogbot September 12, 2025 05:48 — with GitHub Actions Failure

agrasth force-pushed the mavenFlexpack branch from 15dabf6 to 78989c5 Compare September 12, 2025 06:03

agrasth had a problem deploying to frogbot September 12, 2025 06:03 — with GitHub Actions Failure

agrasth force-pushed the mavenFlexpack branch from 78989c5 to 1e5e5c1 Compare September 12, 2025 07:21

agrasth had a problem deploying to frogbot September 12, 2025 07:21 — with GitHub Actions Failure

agrasth had a problem deploying to frogbot September 12, 2025 11:25 — with GitHub Actions Failure

agrasth had a problem deploying to frogbot September 12, 2025 11:32 — with GitHub Actions Failure

agrasth added the safe to test Approve running integration tests on a pull request label Sep 14, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 14, 2025

agrasth changed the base branch from dev-deprecated-please-target-master-directly to master September 16, 2025 07:15

agrasth added the safe to test Approve running integration tests on a pull request label Sep 16, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 16, 2025

naveenku-jfrog reviewed Sep 16, 2025

View reviewed changes

agrasth had a problem deploying to frogbot September 16, 2025 13:01 — with GitHub Actions Failure

agrasth force-pushed the mavenFlexpack branch from b978b0f to 8fb9220 Compare September 17, 2025 21:10

agrasth had a problem deploying to frogbot September 17, 2025 21:10 — with GitHub Actions Failure

agrasth force-pushed the mavenFlexpack branch 2 times, most recently from f75cff3 to 3cfdf8d Compare September 22, 2025 20:25

ehl-jf added the safe to test Approve running integration tests on a pull request label Sep 22, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 22, 2025

agrasth force-pushed the mavenFlexpack branch from 3cfdf8d to 921aebe Compare September 22, 2025 20:30

agrasth requested review from bhanurp September 24, 2025 11:11

ehl-jf added the safe to test Approve running integration tests on a pull request label Sep 24, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 24, 2025

agrasth mentioned this pull request Sep 28, 2025

Add FlexPack business logic from jfrog-cli jfrog/jfrog-cli-artifactory#261

Merged

5 tasks

agrasth force-pushed the mavenFlexpack branch from e968b71 to f5466a8 Compare September 29, 2025 06:46

ehl-jf added the safe to test Approve running integration tests on a pull request label Sep 29, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 29, 2025

agrasth force-pushed the mavenFlexpack branch from f5466a8 to f1e4b32 Compare September 29, 2025 08:03

ehl-jf added the safe to test Approve running integration tests on a pull request label Sep 29, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 29, 2025

agrasth force-pushed the mavenFlexpack branch from f1e4b32 to cbfcb89 Compare September 30, 2025 09:50

ehl-jf added the safe to test Approve running integration tests on a pull request label Sep 30, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 30, 2025

agrasth force-pushed the mavenFlexpack branch from cbfcb89 to a549f18 Compare September 30, 2025 10:06

ehl-jf added the safe to test Approve running integration tests on a pull request label Sep 30, 2025

github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 30, 2025

agrasth added 9 commits September 30, 2025 15:45

Merge upstream/master into mavenFlexpack branch

8b13328

- Resolved conflicts in go.mod and go.sum - Kept local development paths for build-info-go and jfrog-cli-artifactory - Updated to latest upstream dependencies

Clean up old FlexPack comments and duplicate code in main.go

7e3f00d

- Removed obsolete FlexPack comments that are no longer needed - Removed duplicate CommandNotFound handler - FlexPack is now properly integrated through buildtools CLI

Add debug log for Maven FlexPack routing in buildtools/cli.go

8b03a9e

- Added log.Debug message when JFROG_RUN_NATIVE is detected - This provides better visibility into when FlexPack is being used - Consistent with the logging in jfrog-cli-artifactory/artifactory/commands/mvn/utils.go

Restore debug log for Maven FlexPack routing

5921603

- Re-added the log.Debug message that was accidentally removed - This debug message helps track when JFROG_RUN_NATIVE routing is used

Fix duplicate log import in buildtools/cli.go

32b305e

- Removed duplicate import of jfrog-cli-core/v2/utils/log - The file already uses jfrog-client-go/utils/log package - This fixes the build error with redeclared log package

fluxxBot approved these changes Oct 4, 2025

View reviewed changes

Merge upstream master into mavenFlexpack

bcd092f

BrewTestBot mentioned this pull request Oct 16, 2025

jfrog-cli 2.81.0 Homebrew/homebrew-core#249849

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Maven native implementation using flexpack#3081

Added Maven native implementation using flexpack#3081
agrasth merged 17 commits intojfrog:masterfrom
agrasth:mavenFlexpack

agrasth commented Sep 11, 2025 •

edited

Loading

Uh oh!

naveenku-jfrog Sep 16, 2025

Uh oh!

agrasth Sep 17, 2025

Uh oh!

naveenku-jfrog Sep 16, 2025

Uh oh!

naveenku-jfrog Sep 16, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

agrasth commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add FlexPack Maven Support to JFrog CLI

Summary

Changes Made

FlexPack Integration

Test Enhancements

Dependencies

Files Modified

Uh oh!

naveenku-jfrog Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

agrasth Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

naveenku-jfrog Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

naveenku-jfrog Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

agrasth commented Sep 11, 2025 •

edited

Loading