Improve Usage metrics collection on jfrog-cli#3084
Merged
bhanurp merged 6 commits intojfrog:masterfrom Sep 17, 2025
Merged
Conversation
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
itsmeleela
reviewed
Sep 16, 2025
| for _, next := range c.Args() { | ||
| if !strings.HasPrefix(next, "-") { | ||
| continue | ||
| } |
Collaborator
There was a problem hiding this comment.
Minor comment and can be handled later too - but I feel we can make it readable by using helper functions per case. Nested if - else case making it less readable and less extensible IMO
Contributor
Author
There was a problem hiding this comment.
yes this can be improved, I will update.
itsmeleela
approved these changes
Sep 16, 2025
bhanurp
force-pushed
the
usage-metrics
branch
from
db08747 to
dcb4415
Compare
naveenku-jfrog
pushed a commit
to naveenku-jfrog/jfrog-cli
that referenced
this pull request
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....PR Description
The existing usage metrics collects only the command name. This PR adds more details into usage metrics to understand jfrog cli command usage
Depends On
jfrog-cli-core
jfrog-cli-artifactory