-
Notifications
You must be signed in to change notification settings - Fork 277
Feature/added native helm commands support #3235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
naveenku-jfrog
merged 33 commits into
jfrog:master
from
naveenku-jfrog:feature/Added-native-helm-commands-support
Dec 10, 2025
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
b3e3643
Added native helm commands support without buildinfo
naveenku-jfrog 4722065
Added native helm commands docs
naveenku-jfrog 063b709
Updated helm help doc
naveenku-jfrog e40633d
Addressing test failures
naveenku-jfrog b2d5ae9
Marked helm commands as hidden until its complete implementation is done
naveenku-jfrog 94b1ade
Added support for helm package manager commands
naveenku-jfrog 86965b3
Addressing git merge conflicts issues
naveenku-jfrog a99a87e
Addressing git merge conflicts
naveenku-jfrog 92f23e6
Adjusting test params
naveenku-jfrog 2f35edf
Adjusting tests conditions to be triggered
naveenku-jfrog 51c4ea7
Added support for helm package manager commands
naveenku-jfrog 11d1823
Refactored code
naveenku-jfrog d249a3e
Fixing test case
naveenku-jfrog 1c045a4
Fixing test case
naveenku-jfrog 08b771f
Fixing test case
naveenku-jfrog bfacc76
Fixing test case
naveenku-jfrog 05bcb43
Updated test data for http or https
naveenku-jfrog 26d22e0
Updated test data for kuberntes failure
naveenku-jfrog 53cadbb
Updated test data for kuberntes failure
naveenku-jfrog bc17195
Updated test data for kuberntes failure
naveenku-jfrog 0a724dc
Addressed comments
naveenku-jfrog e37d81e
Addressing static failures
naveenku-jfrog 6705120
Updating jfrog-cli-artifactory tests
naveenku-jfrog c84de91
Updating jfrog-cli-artifactory version
naveenku-jfrog b59e478
Updating jfrog-cli-artifactory version
naveenku-jfrog 72b57df
Updating integration test failures
naveenku-jfrog 1209278
Updating integration test failures
naveenku-jfrog b842478
Updating integration test failures
naveenku-jfrog 8836406
Adding more test for packageAndPushCommand 's BuildInfo
naveenku-jfrog 4195682
Removing helm changes in artifactory workflow
naveenku-jfrog 2fbb875
Merge branch 'master' into feature/Added-native-helm-commands-support
naveenku-jfrog 49a706b
Merge branch 'master' into feature/Added-native-helm-commands-support
naveenku-jfrog 958baa3
Addressing comments
naveenku-jfrog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| name: Helm Tests | ||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - "master" | ||
| # Triggers the workflow on PRs to master branch only. | ||
| pull_request_target: | ||
| types: [labeled] | ||
| branches: | ||
| - "master" | ||
|
|
||
| # Ensures that only the latest commit is running for each PR at a time. | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| jobs: | ||
| Helm-Tests: | ||
| name: Helm tests (${{ matrix.os.name }}) | ||
| if: github.event_name == 'workflow_dispatch' || github.event_name == 'push' || contains(github.event.pull_request.labels.*.name, 'safe to test') | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: | ||
| - name: ubuntu | ||
| version: 24.04 | ||
| - name: windows | ||
| version: 2022 | ||
| - name: macos | ||
| version: 14 | ||
| runs-on: ${{ matrix.os.name }}-${{ matrix.os.version }} | ||
| steps: | ||
| - name: Skip macOS - JGC-413 | ||
| if: matrix.os.name == 'macos' | ||
| run: | | ||
| echo "::warning::JGC-413 - Skip until artifactory bootstrap in osx is fixed" | ||
| exit 0 | ||
|
|
||
| - name: Checkout code | ||
| if: matrix.os.name != 'macos' | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha || github.ref }} | ||
|
|
||
| - name: Setup Go with cache | ||
| if: matrix.os.name != 'macos' | ||
| uses: jfrog/.github/actions/install-go-with-cache@main | ||
|
|
||
| - name: Install Helm | ||
| if: matrix.os.name != 'macos' | ||
| uses: azure/setup-helm@v4 | ||
| with: | ||
| version: 'latest' | ||
|
|
||
| - name: Debug macOS Environment and Set Timeout | ||
| if: runner.os == 'macOS' | ||
| run: | | ||
| echo "=== macOS Debug Information ===" | ||
| echo "Architecture: $(uname -m)" | ||
| echo "macOS Version: $(sw_vers -productVersion)" | ||
| echo "macOS Build: $(sw_vers -buildVersion)" | ||
| echo "Available memory: $(system_profiler SPHardwareDataType | grep Memory || echo 'Memory info not available')" | ||
| echo "Available disk space: $(df -h)" | ||
| echo "Java version: $(java -version 2>&1 || echo 'Java not found')" | ||
| echo "Go version: $(go version)" | ||
| echo "Setting RT_CONNECTION_TIMEOUT_SECONDS to 2400 for macOS" | ||
| echo "RT_CONNECTION_TIMEOUT_SECONDS=2400" >> $GITHUB_ENV | ||
|
|
||
| - name: Install local Artifactory | ||
| if: matrix.os.name != 'macos' | ||
| uses: jfrog/.github/actions/install-local-artifactory@main | ||
| with: | ||
| RTLIC: ${{ secrets.RTLIC }} | ||
| RT_CONNECTION_TIMEOUT_SECONDS: ${{ env.RT_CONNECTION_TIMEOUT_SECONDS || '1200' }} | ||
|
|
||
| - name: Get ID Token and Exchange Token | ||
| if: matrix.os.name != 'macos' | ||
| shell: bash | ||
| run: | | ||
| ID_TOKEN=$(curl -sLS -H "User-Agent: actions/oidc-client" -H "Authorization: Bearer $ACTIONS_ID_TOKEN_REQUEST_TOKEN" \ | ||
| "${ACTIONS_ID_TOKEN_REQUEST_URL}&audience=jfrog-github" | jq .value | tr -d '"') | ||
| echo "JFROG_CLI_OIDC_EXCHANGE_TOKEN_ID=${ID_TOKEN}" >> $GITHUB_ENV | ||
|
|
||
| - name: Run Helm tests | ||
| if: matrix.os.name != 'macos' | ||
| run: go test -v github.com/jfrog/jfrog-cli --timeout 0 --test.helm --jfrog.url=http://127.0.0.1:8082 --jfrog.adminToken=${{ env.JFROG_TESTS_LOCAL_ACCESS_TOKEN }} | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package helmcommand | ||
|
|
||
| var Usage = []string{"helm <helm arguments> [command options]"} | ||
|
|
||
| func GetDescription() string { | ||
| return "Run native Helm command" | ||
| } | ||
|
|
||
| func GetArguments() string { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you please add examples on how to use it |
||
| return ` Examples: | ||
|
|
||
| $ jf helm push mychart-0.1.0.tgz oci://myrepo.jfrog.io/helm-local --build-name=my-build --build-number=1 | ||
|
|
||
| $ jf helm package ./mychart --build-name=my-build --build-number=1 | ||
|
|
||
| $ jf helm dependency update ./mychart --build-name=my-build --build-number=1 | ||
|
|
||
| Commands: | ||
|
|
||
| install Install a chart. | ||
|
|
||
| upgrade Upgrade a release. | ||
|
|
||
| package Package a chart directory into a chart archive. | ||
|
|
||
| push Push a chart to remote. | ||
|
|
||
| pull Download a chart from remote. | ||
|
|
||
| repo Add, list, remove, update, and index chart repositories. | ||
|
|
||
| dependency Manage a chart's dependencies. | ||
|
|
||
| help, h Show help for any command.` | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are too many redundant new lines across the code please remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed it.