Skip to content

Fix for 'include' flag with spec file #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agrasth merged 5 commits into from
Dec 10, 2025
Merged

Fix for 'include' flag with spec file #3249

agrasth merged 5 commits into from
Dec 10, 2025

Conversation

@agrasth
Copy link
Contributor

@agrasth agrasth commented Dec 2, 2025 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Fix: --include Flag Ignored When Using Spec Files in Search Command

Description

Fixes bug where the --include flag was ignored when using spec files with jf rt search, causing all fields to be returned instead of only the specified fields.

Before Fix:

jf rt search --spec=spec.json --include="name" --limit=1
# Returns: ALL fields (path, type, size, created, modified, sha1, sha256, md5, props) ❌

After Fix:

jf rt search --spec=spec.json --include="name" --limit=1
# Returns: LIMITED fields (path, props only) ✅

Related PR:

@agrasth agrasth mentioned this pull request Dec 2, 2025
Merged
4 tasks
@agrasth agrasth added bug Something isn't working safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 2, 2025
@agrasth agrasth requested a review from reshmifrog December 2, 2025 07:23
@agrasth agrasth force-pushed the include-flag-fix branch 4 times, most recently from 5a8c79c to c61afca Compare December 5, 2025 09:32
@agrasth agrasth added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 6, 2025
@reshmifrog
Copy link
Contributor

reshmifrog commented Dec 8, 2025

  • please have a look why these tests are failing before merging

@agrasth agrasth force-pushed the include-flag-fix branch 2 times, most recently from 969edd6 to 7dfb507 Compare December 9, 2025 18:04
@agrasth agrasth added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 9, 2025
@agrasth
Fix for 'include' flag with spec file
1bc5c37 
Use public Include field for direct assignment.
Point to local jfrog-cli-core for development.
@agrasth
Add e2e test for 'include' flag with spec file
c655be5
@agrasth
fix: address unsafe deserialization vulnerability in GitHub API respo…
cc873dc 
…nse handling

- Use json.Decoder with DisallowUnknownFields for safer deserialization
- Add validation for version tag format to ensure it matches semantic versioning
- Add 10MB size limit to HTTP response body to prevent potential DoS attacks
- Addresses Frogbot SAST finding for go-unsafe-deserialization
@agrasth agrasth added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 10, 2025
@agrasth agrasth enabled auto-merge (squash) December 10, 2025 11:59
@agrasth agrasth added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

@agrasth agrasth merged commit 95128d4 into jfrog:master Dec 10, 2025
68 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reshmifrog reshmifrog reshmifrog approved these changes

Assignees

No one assigned

Labels

bug Something isn't working safe to test Approve running integration tests on a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agrasth @reshmifrog