Skip to content

RTECO-235 - Refactoring code#1149

Merged
naveenku-jfrog merged 2 commits intojfrog:devfrom
naveenku-jfrog:fix/Refactor-code
Jul 15, 2025
Merged

RTECO-235 - Refactoring code#1149
naveenku-jfrog merged 2 commits intojfrog:devfrom
naveenku-jfrog:fix/Refactor-code

Conversation

@naveenku-jfrog
Copy link
Contributor

@naveenku-jfrog naveenku-jfrog commented Jul 10, 2025

Problem Statement: Code is complex for handling repoOnly change

Solution:

  1. Removed the logic for running for setting properties for repo only on separate thread, as we know that only API request will be there, so no need to do overcomplex things.
  2. Also reduced complexity in performRequest function which is for handling for artifacts.

Related PRs: jfrog/jfrog-cli-artifactory#103

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@naveenku-jfrog naveenku-jfrog added the safe to test Approve running integration tests on a pull request label Jul 11, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 11, 2025
@naveenku-jfrog naveenku-jfrog added the safe to test Approve running integration tests on a pull request label Jul 15, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 15, 2025
@bhanurp bhanurp self-requested a review July 15, 2025 06:28
@bhanurp bhanurp added improvement Automatically generated release notes ignore for release Automatically generated release notes labels Jul 15, 2025
@naveenku-jfrog naveenku-jfrog added improvement Automatically generated release notes ignore for release Automatically generated release notes and removed improvement Automatically generated release notes ignore for release Automatically generated release notes labels Jul 15, 2025
@naveenku-jfrog naveenku-jfrog merged commit dc14f9e into jfrog:dev Jul 15, 2025
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants