Skip to content

Fix proxy configuration and command output handling#549

Open
attiasas wants to merge 3 commits intojfrog:masterfrom
attiasas:claude/hungry-tharp
Open

Fix proxy configuration and command output handling#549
attiasas wants to merge 3 commits intojfrog:masterfrom
attiasas:claude/hungry-tharp

Conversation

@attiasas
Copy link
Contributor

Changes

  • Proxy Configuration: Fix proxy not being picked up from VS Code settings for both extension and analyzer

    • Added fallback to HTTPS_PROXY and HTTP_PROXY environment variables when VS Code proxy setting is not configured
    • Simplified proxy URL handling in analyzer to set both HTTP and HTTPS proxy environment variables from single VS Code proxy configuration (HTTP proxy handles both via CONNECT tunneling)
  • Command Output: Fix displaying both StdOut and StdErr

    • Added Utils.combineStdoutAndStderr() helper to properly combine stdout and stderr output
    • Updated ScanUtils.executeCommand() to use the new helper for better error message visibility
  • Agentic Coding: Fixed disabled agentic when copilot is installed but fails to report as enabled

    • Updated enablement condition to only check jfrog.agneticCodingEnabled instead of requiring both copilot installed and agentic enabled
  • Version: Bumped to 2.14.8

  • Tests: Added comprehensive tests for proxy configuration fallback and analyzer environment variable handling

…analyzer

- analyzerManager: set both HTTP_PROXY and HTTPS_PROXY from VS Code proxy
  config regardless of proxy URL protocol. An http:// proxy handles HTTPS
  traffic via CONNECT tunneling, so restricting it to only HTTP_PROXY broke
  connections to HTTPS JFrog servers.
- connectionUtils: add fallback to HTTPS_PROXY/HTTP_PROXY env vars in
  getProxyConfig() when http.proxy VS Code setting is not configured.
- Add tests covering VS Code http:// proxy setting and env-var fallback.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Mar 17, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 17, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 17, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 17, 2026
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 17, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 17, 2026
@attiasas attiasas requested a review from a team March 17, 2026 15:08
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Mar 19, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 19, 2026
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants