-
Notifications
You must be signed in to change notification settings - Fork 106
Migrate OIDC Token Exchange from Action to CLI #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.✅ What’s Changed
🔁 Simplified OIDC Token Exchange Logic
The action now leverages the JFrog CLI’s native support for
--oidc-token-id, which accepts a GitHub-issued OIDC token.This removes the need for manual API calls to
/oidc/token, reducing complexity and improving maintainability.🧼 Refactored Credential Resolution
The
getJfrogCredentials()logic is now cleaner and more intuitive:oidc-provider-nameis provided → fetch and inject GitHub OIDC token.JF_ACCESS_TOKENJF_USER+JF_PASSWORD✅ OIDC Validation Checks
The action now enforces:
2.75.0--download-repositorycannot be used with OIDC (credentials unavailable before config)🧹 Removed Legacy Code
oidc-token,oidc-user🧪 Improved Test Coverage
New tests were added for:
✅ Supported
JF_ACCESS_TOKENJF_USER+JF_PASSWORDoidc-provider-name(when using CLI ≥2.75.0)❌ Not Supported
--download-repositorywith OIDC (blocked by validation)2.75.0with OIDC (unsupported--oidc-token-id)📚 Documentation Updates
README.mdupdated to:oidc-token,oidc-user)🔗 Related Work