-
Notifications
You must be signed in to change notification settings - Fork 106
Enable Dual OIDC Integration Flow with Backward Compatibility #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7756d69
And new OIDC method and keep the old one
EyalDelarea e59274e
Update tests
EyalDelarea fddc089
CR
EyalDelarea c0b7470
Update README.md
EyalDelarea 2f5ebd1
Trigger workflows on fork until merge
EyalDelarea 69a1a8e
Merge branch 'master' of https://github.com/jfrog/setup-jfrog-cli int…
EyalDelarea 95e3044
cr
EyalDelarea b4b205f
CR
EyalDelarea 6a125cb
Bump CLI version and prepare for merge
EyalDelarea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| # This action is an integration test for OIDC workflow | ||
| name: CLI OpenID Connect Test | ||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| - "**" | ||
|
|
||
| # Triggers the workflow on labeled PRs only. | ||
| pull_request_target: | ||
| types: [ labeled ] | ||
|
|
||
|
|
||
| # Ensures that only the latest commit is running for each PR at a time. | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
| permissions: | ||
| id-token: write | ||
| jobs: | ||
| OIDC-Test: | ||
| if: contains(github.event.pull_request.labels.*.name, 'safe to test') || github.event_name == 'push' | ||
| name: OIDC-Access integration test (${{ matrix.os }}) | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ ubuntu, windows, macos ] | ||
| runs-on: ${{ matrix.os }}-latest | ||
| steps: | ||
| - name: Checkout Repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: | ||
| ${{ github.event.pull_request.head.ref || github.sha }} | ||
|
|
||
| - name: Setup JFrog CLI | ||
| id: setup-jfrog-cli | ||
| uses: ./ | ||
| env: | ||
| JF_URL: ${{ secrets.JFROG_PLATFORM_URL }} | ||
| with: | ||
| oidc-provider-name: setup-jfrog-cli-test | ||
|
|
||
| - name: Test JFrog CLI | ||
| run: | | ||
| jf rt ping | ||
6 changes: 4 additions & 2 deletions
6
.github/workflows/oidc-test.yml → .github/workflows/manual-oidc-test.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.