Skip to content

feat: add support to iso charset #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add support to iso charset #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lib/src/metadata_fetch_base.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import 'dart:convert';
import 'package:html/dom.dart';
import 'package:http/http.dart' as http;
import 'package:html/parser.dart' as parser;
import 'package:http_parser/http_parser.dart' show MediaType;
import 'package:metadata_fetch/metadata_fetch.dart';
import 'package:metadata_fetch/src/parsers/parsers.dart';
import 'package:metadata_fetch/src/utils/util.dart';
Expand Down Expand Up @@ -52,14 +53,27 @@ class MetadataFetch {

Document? document;
try {
document = parser.parse(utf8.decode(response.bodyBytes));
final charset =
_getCharsetFromContentType(response.headers['content-type'] ?? '');
///validate if charset is utf-8
final decodedBody = charset == 'utf-8'
? utf8.decode(response.bodyBytes)
: latin1.decode(response.bodyBytes);

document = parser.parse(decodedBody);
} catch (err) {
return document;
}

return document;
}

/// Extracts the character encoding (charset) from the Content-Type header.
static String _getCharsetFromContentType(String contentTypeHeader) {
final mediaType = MediaType.parse(contentTypeHeader);
return mediaType.parameters['charset'] ?? 'utf-8';
}

/// Returns instance of [Metadata] with data extracted from the [html.Document]
/// Provide a given url as a fallback when there are no Document url extracted
/// by the parsers.
Expand Down