enabled pipelines env var and npm-oidc #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgilbert01
commented
Oct 16, 2025
| - run: npm test | ||
| - run: npm publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{secrets.NODE_AUTH_TOKEN}} |
Owner
Author
There was a problem hiding this comment.
- i setup the trusted publisher on the npm side
- i think these r the only changes needed on this side
petermyers
approved these changes
Oct 20, 2025
petermyers
reviewed
Oct 31, 2025
src/pipelines/index.js
Outdated
| const assemble = (opt) => (head, includeFaultHandler = true) => { | ||
| const disabledPipelines = process.env.DISABLED_PIPELINES?.split(','); | ||
| const enabledPipelines = (opt.ENABLED_PIPELINES || process.env.ENABLED_PIPELINES)?.split(','); | ||
| const disabledPipelines = (opt.DISABLED_PIPELINES || process.env.DISABLED_PIPELINES)?.split(','); |
Collaborator
There was a problem hiding this comment.
For sure fine as is, but I’ve been burned by this before…should we add a .map(pipeline => pipeline.trim() to the end of these to catch someone adding a space after a comma in the envar?
petermyers
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.