Fix fully covered region detection for inverted pyramid shapes by Copilot · Pull Request #166 · jgphilpott/polyslice

Copilot · 2026-02-28T11:27:45Z

Understand the issue: inverted pyramid transition layers not generating O-shape skin + center FILL
Identify root cause: identifyFullyCoveredRegions in cavity.coffee only handles smaller-region-from-above case
Add test for inverted pyramid fully covered region detection
Fix identifyFullyCoveredRegions to also handle smaller-region-from-below case
Regenerate pyramid gcode examples
Run tests to verify fix (31/31 exposure tests passing)
Refactor two near-identical passes into shared findCoveredRegions helper (review comment 2867625981)
Remove unused layer52Started variable from test (review comment 2867625986)
touchesBoundary guard centralized in helper, consistently applied to candidate in both passes (review comment 2867625988)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: jgphilpott <4128208+jgphilpott@users.noreply.github.com>

Copilot

Pull request overview

This PR updates cavity “fully covered region” detection so transition layers also handle inverted step geometries (smaller region below the transition), producing the intended O-shaped skin + center infill behavior for inverted pyramids and similar shapes.

Changes:

Add a symmetric second pass in identifyFullyCoveredRegions to detect fully covered regions when the smaller covering region is below the current layer.
Add a regression test that slices an inverted two-slab mesh and asserts center-region behavior on the transition layer.
Regenerate a large set of example/benchmark G-code outputs and bump three patch version.

Reviewed changes

Copilot reviewed 86 out of 87 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/slicer/skin/exposure/cavity.coffee	Adds a second-pass fully-covered-region detection for inverted geometries.
src/slicer/skin/exposure/cavity.test.coffee	Adds a regression test for inverted-pyramid transition-layer behavior.
resources/gcode/support/tree/dome/upright.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/support/normal/dome/upright.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/skin/pyramid/cylindrical-inverted.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/skin/pyramid/block-inverted.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/skin/dome/upright.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/triangles/sphere/0%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/triangles/sphere/10%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/triangles/sphere/20%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/triangles/sphere/30%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/triangles/sphere/40%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/triangles/sphere/50%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/triangles/sphere/60%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/triangles/sphere/70%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/triangles/sphere/80%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/triangles/sphere/90%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/triangles/sphere/100%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/spiral/sphere/0%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/spiral/sphere/10%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/spiral/sphere/20%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/spiral/sphere/30%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/spiral/sphere/40%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/spiral/sphere/50%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/spiral/sphere/60%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/spiral/sphere/70%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/spiral/sphere/80%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/spiral/sphere/90%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/spiral/sphere/100%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/lightning/sphere/0%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/lightning/sphere/10%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/lightning/sphere/20%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/lightning/sphere/30%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/lightning/sphere/40%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/lightning/sphere/50%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/lightning/sphere/60%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/lightning/sphere/70%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/lightning/sphere/80%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/lightning/sphere/90%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/lightning/sphere/100%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/hexagons/sphere/0%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/hexagons/sphere/10%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/hexagons/sphere/20%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/hexagons/sphere/30%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/hexagons/sphere/40%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/hexagons/sphere/50%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/hexagons/sphere/60%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/hexagons/sphere/70%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/hexagons/sphere/80%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/hexagons/sphere/90%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/hexagons/sphere/100%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/gyroid/sphere/0%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/gyroid/sphere/10%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/gyroid/sphere/20%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/gyroid/sphere/30%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/gyroid/sphere/40%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/gyroid/sphere/50%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/gyroid/sphere/60%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/gyroid/sphere/70%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/gyroid/sphere/80%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/gyroid/sphere/90%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/gyroid/sphere/100%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/grid/sphere/0%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/grid/sphere/10%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/grid/sphere/20%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/grid/sphere/30%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/grid/sphere/40%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/grid/sphere/50%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/grid/sphere/60%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/grid/sphere/70%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/grid/sphere/80%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/grid/sphere/90%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/grid/sphere/100%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/concentric/sphere/0%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/concentric/sphere/10%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/concentric/sphere/20%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/concentric/sphere/30%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/concentric/sphere/40%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/concentric/sphere/50%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/concentric/sphere/60%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/concentric/sphere/70%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/concentric/sphere/80%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/concentric/sphere/90%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/infill/concentric/sphere/100%.gcode	Regenerated G-code (LFS pointer updated).
resources/gcode/benchmarks/benchy.low-poly.gcode	Regenerated benchmark G-code (LFS pointer updated).
package.json	Bumps `three` dependency patch version.
package-lock.json	Updates lockfile for `three@0.183.2`.

src/slicer/skin/exposure/cavity.coffee

src/slicer/skin/exposure/cavity.test.coffee

src/slicer/skin/exposure/cavity.coffee

jgphilpott · 2026-02-28T16:38:44Z

@copilot apply changes based on the comments in this thread

…d layer52Started Co-authored-by: jgphilpott <4128208+jgphilpott@users.noreply.github.com>

Initial plan

c0bbf13

Copilot AI assigned Copilot and jgphilpott Feb 28, 2026

Copilot started work on behalf of jgphilpott February 28, 2026 11:27 View session

Fix inverted pyramid fully covered region detection in cavity.coffee

3e39c94

Co-authored-by: jgphilpott <4128208+jgphilpott@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix skin patch generation for inverted pyramid examples~~ Fix fully covered region detection for inverted pyramid shapes Feb 28, 2026

Copilot finished work on behalf of jgphilpott February 28, 2026 11:45

jgphilpott added 2 commits February 28, 2026 19:28

resources update

4294bfc

node update

452748b

jgphilpott marked this pull request as ready for review February 28, 2026 16:30

Copilot AI review requested due to automatic review settings February 28, 2026 16:30

Copilot started reviewing on behalf of jgphilpott February 28, 2026 16:30 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

src/slicer/skin/exposure/cavity.coffee Outdated Show resolved Hide resolved

src/slicer/skin/exposure/cavity.test.coffee Show resolved Hide resolved

src/slicer/skin/exposure/cavity.coffee Outdated Show resolved Hide resolved

Copilot started work on behalf of jgphilpott February 28, 2026 16:38 View session

Refactor identifyFullyCoveredRegions into shared helper; remove unuse…

8cca9be

…d layer52Started Co-authored-by: jgphilpott <4128208+jgphilpott@users.noreply.github.com>

Copilot finished work on behalf of jgphilpott February 28, 2026 16:45

jgphilpott approved these changes Feb 28, 2026

View reviewed changes

jgphilpott merged commit 3a64932 into main Feb 28, 2026
1 check passed

jgphilpott deleted the copilot/fix-inverted-pyramid-skin-patch branch February 28, 2026 17:04

Copilot AI mentioned this pull request Mar 8, 2026

Release v26.3.0 #183

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix fully covered region detection for inverted pyramid shapes#166

Fix fully covered region detection for inverted pyramid shapes#166
jgphilpott merged 5 commits intomainfrom
copilot/fix-inverted-pyramid-skin-patch

Copilot AI commented Feb 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jgphilpott commented Feb 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jgphilpott commented Feb 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 28, 2026 •

edited

Loading