Remove vendor prefixes from sass #3931
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new feature | improvement | bugfix | documentation fix.
Proposed solution
When debugging some other issues with placeholders in my application, I noticed some vendor prefixes popping up on attributes where I did not expect them. Then I figured that they are actually hardcoded within the scope of this repository, rather than applied by tooling (e.g.
autoprefixer).Edit: for the
::placeholdermixin, it was actually rendering all the variants except for the correct modern::placeholderpseudo-element, so this actually might ensure proper behavior across environments that previously did not work.This PR removes the hardcoded vendor-prefixed variants of some properties. The preferred way (I think) should be using tooling to handle this. Although the
READMEmentions thatautoprefixeris used within this repository, it seems it has since been replaced withcssnano, which may not include it by default.Probably this requires rebuilding
csstoo, however thenpm run buildalias mentioned inCONTRIBUTING.mdno longer exists, so I'm not sure which parts are intended to run on MR submissions.Note: I encountered this issue on version
v0.9.4, but I'm not sure if bugfixes are still welcome for the old version?Tradeoffs
Theoretically this could cause a change of behavior on legacy browsers. Given the wide availability of the non-prefixed alternatives and the fact that tooling like
autoprefixeris commonly used, I suspect this will have little to no impact in that regard.Testing Done
None.
Changelog updated?
No.