Fixed the url generated by DADict's add_action(url_only=True) and other add_action() improvements#878
Merged
jhpyle merged 3 commits intojhpyle:masterfrom Jan 1, 2026
Conversation
jpagh
changed the title
DADict's add_action(url_only=True) and other add_action() improvements
jpagh
changed the title
DADict's add_action(url_only=True) and other add_action() improvementsDADict's add_action(url_only=True) and other add_action() improvements
…method to match DAList implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The url generated by
DADict.add_action(url_only=True)causes an error because it's the wrong type.Added
the_urlvariable so that the url doesn't have to be written/changed in two places.DADict: added
_add_action_button()method and updatedadd_action()method to match DAList implementation