This repository was archived by the owner on Jul 13, 2018. It is now read-only.
Refactor DfsBlockCache and make it pluggable#1
Open
jiahuijiang wants to merge 3 commits intomasterfrom
Open
Conversation
- Made a `DfsBlockCache` abstract class - Renamed the original `DfsBlockCache` into `DefaultDfsBlockCache` and refactor to make it extend `DfsBlockCache`
schlosna
reviewed
Feb 17, 2017
| } | ||
| public static void resetCache(DfsBlockCache newCache) { | ||
| DfsBlockCache oldCache = cache; | ||
| cache = newCache; |
There was a problem hiding this comment.
probably want to make the cache an AtomicReference to do DfsBlockCache oldCache = cache.getAndSet(newCache); as there's currently a possible race condition here for multiple concurrent calls.
nit: might want to name method as set or setInstance
|
note (that you probably know already, but just in case): when you want to merge this into jgit you need to do it via gerrit, not a github PR |
|
although meanwhile we can depend on a forked version built from this repo which is good! |
| } | ||
| } | ||
| static { | ||
| cache = new AtomicReference<>(); |
There was a problem hiding this comment.
nit: maybe we should do this in the same line as the declaration?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DfsBlockCacheabstract classDfsBlockCacheintoDefaultDfsBlockCacheand refactor to make it extend
DfsBlockCache