Skip to content

Comments

Improve task implementations#111

Merged
jiakuan merged 6 commits intojiakuan:mainfrom
larsgrefer:cleanup
Oct 22, 2025
Merged

Improve task implementations#111
jiakuan merged 6 commits intojiakuan:mainfrom
larsgrefer:cleanup

Conversation

@larsgrefer
Copy link
Contributor

No description provided.

@jiakuan jiakuan requested a review from Copilot October 18, 2025 08:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors GWT task implementations from constructor-based dependency injection to abstract properties, improving Configuration Cache compatibility and modernizing the plugin architecture.

  • Replaced manual property initialization in constructors with abstract property getters using Gradle's managed properties
  • Migrated from immediate argument configuration to lazy argument providers for better Configuration Cache support
  • Added utility class for standardized command-line argument handling

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
GwtSuperDevTask.java Converted from constructor injection to abstract properties with annotations
GwtDevModeTask.java Converted from constructor injection to abstract properties with annotations
GwtCompileTask.java Converted from constructor injection to abstract properties with annotations
AbstractBaseTask.java Replaced immediate argument configuration with lazy argument providers and utility methods
ArgumentListUtils.java New utility class providing standardized command-line argument mapping methods
GwtSuperDevConfig.java Removed deprecated configureArgs() call
GwtDevModeConfig.java Removed deprecated configureArgs() call
GwtCompileConfig.java Removed deprecated configureArgs() call
GwtPlugin.java Added version rejection for milestone release

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jiakuan jiakuan merged commit aab9dfd into jiakuan:main Oct 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants