Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors GWT task implementations from constructor-based dependency injection to abstract properties, improving Configuration Cache compatibility and modernizing the plugin architecture.
- Replaced manual property initialization in constructors with abstract property getters using Gradle's managed properties
- Migrated from immediate argument configuration to lazy argument providers for better Configuration Cache support
- Added utility class for standardized command-line argument handling
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| GwtSuperDevTask.java | Converted from constructor injection to abstract properties with annotations |
| GwtDevModeTask.java | Converted from constructor injection to abstract properties with annotations |
| GwtCompileTask.java | Converted from constructor injection to abstract properties with annotations |
| AbstractBaseTask.java | Replaced immediate argument configuration with lazy argument providers and utility methods |
| ArgumentListUtils.java | New utility class providing standardized command-line argument mapping methods |
| GwtSuperDevConfig.java | Removed deprecated configureArgs() call |
| GwtDevModeConfig.java | Removed deprecated configureArgs() call |
| GwtCompileConfig.java | Removed deprecated configureArgs() call |
| GwtPlugin.java | Added version rejection for milestone release |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.