fix: handle 404 in team_member Read without string matching#783
Open
bennettip wants to merge 1 commit intojianyuan:mainfrom
Open
fix: handle 404 in team_member Read without string matching#783bennettip wants to merge 1 commit intojianyuan:mainfrom
bennettip wants to merge 1 commit intojianyuan:mainfrom
Conversation
bennettip
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the same issue as #777 (and the original #655/#447).
Instead of using pattern matching to try to capture different 404 messages, this PR checks the HTTP status codes directly from the source (
getEffectiveTeamRole()) and returns non found error if404is encounted.