Open
Conversation
|
|
||
| /* macOS and Solaris do not have it */ | ||
| #ifndef MSG_NOSIGNAL | ||
| #define MSG_NOSIGNAL 0 |
There was a problem hiding this comment.
MSG_NOSIGNAL should be defined as SO_NOSIGPIPE.
Author
There was a problem hiding this comment.
How sure are you? I have seen a fallback to 0 used elsewhere, like lpeterse/haskell-socket@0aa0db5
There was a problem hiding this comment.
The suggested behavior is better for macOS, but yeah, it needs to be wrapped in #ifdef __APPLE__ macros.
Author
There was a problem hiding this comment.
I will try it then.
P. S. It should probably be included into legacysupport.
Owner
There was a problem hiding this comment.
MSG_NOSIGNALshould be defined asSO_NOSIGPIPE.
Not correct -- SO_NOSIGPIPE is a socket option while MSG_NOSIGNAL is a flag for send.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addressed three issues:
clock_settime(even vialegacy-supportlibrary which MacPorts and pkgsrc use).MSG_NOSIGNALmay not be defined on macOS (but apparently elsewhere too).NOTE_TRIGGERappears in later builds of 10.6 and is not supported prior to that.With these, I can build the library on 10.6 powerpc.