Added a fallback for rebar-less projects that use a Make system instead#80
Open
robashton wants to merge 3 commits intojimenezrick:masterfrom
Open
Added a fallback for rebar-less projects that use a Make system instead#80robashton wants to merge 3 commits intojimenezrick:masterfrom
robashton wants to merge 3 commits intojimenezrick:masterfrom
Conversation
|
It would be really nice if autoload/erlang_complete.erl could be updated with similar changes as well to make dependency module autocompletion work without rebar. |
Author
|
Yikes - I hadn't thought of that (because I don't ever use it!) - I'll see about doing it. |
…me for erlang_complete
Author
|
Okay done! Also removed the check for makefiles - because sod it, if you haven't got a rebar then you'll probably still want default app conventions to work. |
Author
|
Added apps too... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've phased out rebar across our projects (as have others), so if no rebar is present and one of the two popular makefiles is it'd be nice if all this still worked :-)