Skip to content

Conversation

@jimmykane
Copy link
Owner

@jimmykane jimmykane commented Jan 28, 2026

Summary

This PR introduces significant feature enhancements, including a migration to Mapbox GL for maps, new jumps functionality, and clustered markers based on activity colors. It also standardizes codebase conventions for Observables and Signals, refactors chart settings management, and includes various maintenance chores and bug fixes.

Key Changes

🗺️ Maps & Clusters

  • Map Engine Migration: Swapped Leaflet CSS for Mapbox GL in angular.json, signaling a move towards Mapbox for map rendering.
  • Clusters: Implemented clustering logic based on "prevailing activity colors" to enhance data visualization on maps.

🚀 New Features

  • Jumps: Implemented comprehensive tracking and visualization for Jumps (feature: jumps).

🛠️ Refactoring & Codebase Standards

  • Naming Conventions: Updated .agent/rules/rules.md to strictly enforce:
    • Observables: Must use the $ suffix (e.g., user$).
    • Signals: Must NOT use the $ suffix to clearly distinguish reactive state from streams.
  • Chart Settings: Refactored EventCardChartActionsComponent to use AppUserSettingsQueryService for updating settings, moving away from direct user property mutations. This aligns with a cleaner CQRS/Facade pattern.

🐛 Fixes & Improvements

  • Charts: Resolved issues with xAxis configuration.
  • Race Condition: Fixed a race condition interfering with app stability.
  • Logos: Updated/fixed logo assets (e.g., removal of jetbrains.svg).
  • Dependencies: Bumped sl (sports-lib) version and adjusted Firebase versions.
  • Imports: Added logic for "last import ranges" in history imports.

Configuration Updates

  • angular.json: Replaced Leaflet styles with mapbox-gl.css.
  • package.json: Dependency updates for sl and firebase.

@jimmykane jimmykane merged commit 216653c into main Feb 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants