Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6b59a0149
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/app/components/event/activities-toggles/activities-toggles.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 468321211a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| AppEventUtilities.shouldExcludeAscent(activityTypes) | ||
| || (summariesSettings?.removeAscentForEventTypes || []).some((type: string) => (activityTypes as string[]).includes(type)) | ||
| AppEventUtilities.shouldExcludeAscent(normalizedActivityTypes) | ||
| || (summariesSettings?.removeAscentForEventTypes || []).some((type: string) => (normalizedActivityTypes as string[]).includes(type)) |
There was a problem hiding this comment.
getDefaultSummaryStatTypes now canonicalizes incoming activityTypes, but the manual exclusion lists are still compared as raw strings via includes(type). This creates a regression for legacy/non-canonical settings values (e.g., lowercase/alias forms): ascent/descent exclusions no longer match after normalization and the metrics reappear unexpectedly. Normalize each configured exclusion type before the comparison (or compare via a shared canonical/lowercased key) so both sides use the same representation.
Useful? React with 👍 / 👎.
1 participant
Event experience and analytics
Frontend architecture and performance
Admin, account, and monetization flows
Backend and integration updates
functions/src/queue.ts).functions/src/suunto/activities.ts).Tests and quality