Add Windows memory tracking support using psutil#6233
Open
veeceey wants to merge 1 commit intojina-ai:masterfrom
Open
Add Windows memory tracking support using psutil#6233veeceey wants to merge 1 commit intojina-ai:masterfrom
veeceey wants to merge 1 commit intojina-ai:masterfrom
Conversation
Previously, the used_memory() function returned 0 on Windows due to the resource module not being available. This fix implements proper memory tracking for Windows using psutil.Process().memory_info().rss, which is already available as a test dependency. The implementation includes a fallback to return 0 if psutil is not available, maintaining backward compatibility.
Author
|
Friendly ping - any chance someone could take a look at this when they get a chance? Happy to make any changes if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
used_memory()functionresourcemodulepsutil.Process().memory_info().rss(already available as test dependency)Changes
jina/logging/profile.pyto use psutil on WindowsTest plan
Generated with Claude Code