Improve YAML file path validation regex for all platforms#6234
Open
veeceey wants to merge 1 commit intojina-ai:masterfrom
Open
Improve YAML file path validation regex for all platforms#6234veeceey wants to merge 1 commit intojina-ai:masterfrom
veeceey wants to merge 1 commit intojina-ai:masterfrom
Conversation
Previously, the Windows regex was too permissive (matching any string ending in .yaml/.yml) and the Unix regex was too restrictive (only matching absolute paths starting with /). This fix improves both patterns to be more comprehensive: - Windows: Now properly validates paths with drive letters (C:\), UNC paths (\\), relative paths (.\), and regular paths - Unix: Now supports both absolute (/path) and relative (./path or path) file paths The improved patterns better distinguish between YAML file paths and raw YAML content strings.
Author
|
Friendly ping - any chance someone could take a look at this when they get a chance? Happy to make any changes if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan
Generated with Claude Code