Skip to content

Comments

Support custom Procfile #27#28

Open
WilhelmKleuSage wants to merge 4 commits intojincod:masterfrom
WilhelmKleuSage:master
Open

Support custom Procfile #27#28
WilhelmKleuSage wants to merge 4 commits intojincod:masterfrom
WilhelmKleuSage:master

Conversation

@WilhelmKleuSage
Copy link

@WilhelmKleuSage WilhelmKleuSage commented Nov 28, 2017

Basic implementation for #27

When compiling and Procfile found:

  • Read Procfile to find dlls
  • Publish each dll found in Procfile
  • Currently requires cd $HOME/heroku_output in Procfile

When compiling detect Procfile in build directory and then read from Procfile trying to publish all dlls  found in Procfile.
Extract publish to function.

if [ -e "$BUILD_DIR/Procfile" ]; then
numberOfProjects=0
while read line || [[ -n "$line" ]];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WilhelmKleuSage

It does mean support of multiple projects? I think we can't do it, because only one web process instruction per file available

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay in reply, I was away.
The code iterates the entries in the Procfile, try to match a valid dll and then publish.
Use the count of valid projects to determine exit code.
While there can only be one web process type there can be multiple other arbitrarily named processes (worker processes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants