Skip to content

Preserve infinite step ranges in views (#203) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Preserve infinite step ranges in views (#203) #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/infrange.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,10 @@ function getindex(Ac::AdjOrTrans{<:Any,<:InfRanges}, k::Integer, j::InfAxes)
parent(Ac)[j]
end

# views may preserve InfStepRanges
Base.@propagate_inbounds Base.view(r::InfStepRange, i::AbstractUnitRange{<:Integer}) = r[i]
Base.@propagate_inbounds Base.view(r::InfStepRange, i::InfStepRange{<:Integer}) = r[i]
Base.@propagate_inbounds Base.view(r::InfStepRange, i::StepRange{<:Integer}) = r[i]

show(io::IO, r::InfUnitRange) = print(io, repr(first(r)), ':', repr(∞))
show(io::IO, r::OneToInf{Int}) = print(io, "OneToInf()")
Expand Down Expand Up @@ -618,4 +622,4 @@ end
# bounds-checking
function Base.checkindex(::Type{Bool}, inds::NTuple{N, AbstractInfUnitRange}, i::AbstractRange{CartesianIndex{N}}) where {N}
isempty(i) | checkindex(Bool, inds, first(i))
end
end
10 changes: 10 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,16 @@ end
@test (1:-1:-∞)[1:∞] == 1:-1:-∞
end

@testset "view(InfStepRange, inf-range)" begin
r = 2:5:∞
@test view(r, axes(r,1)) === r
@test view(r, 1:1:∞) === r
@test view(r, 2:2:∞) === 7:10:∞
r2 = 2:5:10_000 # arbitrary high upper cutoff
@test view(r, 4:10) == view(r2, 4:10)
@test view(r, 4:7:50) == view(r2, 4:7:50)
end

@testset "OneToInf" begin
r = OneToInf()
@test !isempty(r)
Expand Down
Loading