[v3.1] ottersec: Fix reporting for multi‑tx non‑revert bundles#1178
Closed
haoranjito wants to merge 2 commits intov3.1from
Closed
[v3.1] ottersec: Fix reporting for multi‑tx non‑revert bundles#1178haoranjito wants to merge 2 commits intov3.1from
haoranjito wants to merge 2 commits intov3.1from
Conversation
Reporting for non revert batches was incorrect: it always returned the first transaction's result and ignored the rest. This change updates reporting so non‑revert multi‑tx batches return a single Committed result containing all transaction results when the batch fully commits. If any transaction fails, the response stays NotCommitted with the first failure index (the only shape the AtomicTxnBatchResult proto can represent for mixed outcomes). This is an intentional tradeoff given the proto limitation: it cannot encode partial failures alongside committed results.
haoranjito
changed the title
haoranjito
changed the title
haoranjito
changed the title
Contributor
Author
|
This is not an issue. On the server side, only single tx batch is allowed when no-revert = true. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reporting for non revert batches was incorrect: it always returned the
first transaction's result and ignored the rest. This change updates
reporting so non‑revert multi‑tx batches return a single Committed
result containing all transaction results when the batch fully commits.
If any transaction fails, the response stays NotCommitted with the first
failure index (the only shape the AtomicTxnBatchResult proto can
represent for mixed outcomes).
This is an intentional tradeoff given the proto limitation: it cannot
encode partial failures alongside committed results.
Summary of Changes
Fixes #