fixes resize event stutter on iOS devices#8
Open
taberrr wants to merge 1 commit intojjenzz:masterfrom
Open
Conversation
jjenzz
reviewed
Jul 12, 2017
| return; | ||
| } | ||
| windowWidth = $(window).width(); | ||
|
|
Owner
There was a problem hiding this comment.
@taberrr, thanks for this fix. It would be great if you could cache the window reference and add a comment explaining why this is required though please if you don't mind?
if (base.opts.responsive) {
var $window = $(window);
var windowWidth = $window.width();
var resize = function() {
// Scrolling on iOS6+ fires the resize event. This ensures the width has actually changed
// before continuing. https://tinyurl.com/ios-scroll-resize
if ($window.width() === windowWidth) {
return;
}
windowWidth = $window.width();
//etc.
}
$window.on('resize.' + namespace, resize);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window.onResize event was causing text stuttering/flickering when scrolling the page on iOS devices, so this PR ensures the window's width has actually changed before acting on the resize event.