Conversation
…ge in `mcp_bear` Replaced repetitive request handling logic with a shared `_request` function for consistency across tools. Simplified parameter updates by leveraging unpacking syntax (`**params`). Removed redundant future management and URL construction operations. Updated test cases accordingly.
jkawamoto
force-pushed
the
refactor
branch
2 times, most recently
from
772ef2a to
56a8ad5
Compare
Shifted temporary socket cleanup logic (`os.unlink`) from tests to the primary implementation in `mcp_bear` to ensure proper cleanup after server shutdown.
Updated `runs-on` to `macos-latest` and upgraded `setup-uv` to v7. Switched to specifying Python version directly as `3.13`.
jkawamoto
force-pushed
the
refactor
branch
2 times, most recently
from
3b00bee to
76233b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored request handling logic to use a central
_requestfunction for consistency, reduced redundancy in parameter management with unpacking syntax, and simplified code by removing unnecessary operations. Test cases updated to align with these changes.