You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tried Symlinking it to my Ionic Repo I want to use it in, but it doesn't seem to be working for some reason when I run the Ionic android build and run it on the device to test it.
But wanted throw this up and get some feedback on how I implemented it and if @jkbz64 has any suggestions on edits/fixes or a good way to test this locally on the device by npm link-ing it to the repo I want to use it in.
Aside from the formatting inconsistencies looks mostly correct, good job 👍
There are some things that caught my eye so I will request changes for them right now, to merge the changes completely I will need to test it on the real device somewhere in the coming week (don't have device on hand), might post rest of the requested changes then if any appear.
or a good way to test this locally on the device by npm link-ing it to the repo I want to use it in.
Pretty sure going into the plugin repository and calling npm link then going to your project repository and calling npm link capacitor-datawedge symlinks the repos properly then all you need is to call npx cap sync to sync the plugin files but that is with plain capacitor, haven't used Ionic personally, don't know if that makes a difference.
or a good way to test this locally on the device by npm link-ing it to the repo I want to use it in.
Pretty sure going into the plugin repository and calling npm link then going to your project repository and calling npm link capacitor-datawedge symlinks the repos properly then all you need is to call npx cap sync to sync the plugin files but that is with plain capacitor, haven't used Ionic personally, don't know if that makes a difference.
Ahhhh I forgot the 'npx cap sync' part. Will try that when I get back home. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying my hand at adding a feature to this Repo.
Tried Symlinking it to my Ionic Repo I want to use it in, but it doesn't seem to be working for some reason when I run the Ionic android build and run it on the device to test it.
But wanted throw this up and get some feedback on how I implemented it and if @jkbz64 has any suggestions on edits/fixes or a good way to test this locally on the device by
npm link-ing it to the repo I want to use it in.