Add tx continuations and auto acks#157
Open
diondokter wants to merge 4 commits intojkelleyrtp:masterfrom
Open
Conversation
diondokter
commented
Jan 22, 2025
Comment on lines
-65
to
-71
| // Really weird thing about double buffering I can't find anything about. | ||
| // When a message is received in double buffer mode that should be filtered out, | ||
| // the radio gives a really short fake interrupt. | ||
| // This messes up all the logic, so unless a solution can be found we simply don't support it. | ||
| if RECEIVING::DOUBLE_BUFFERED && config.frame_filtering { | ||
| return Err(Error::RxConfigFrameFilteringUnsupported); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The receiving setup has been moved and is thus hard to review.
Nothing really changed, except for this section which I removed in the PR.
The comment is true. There are useless interrupts, however the driver handles them just fine.
When I put this here 4 years ago, it's likely I was confused. The driver is fine, but my code back then likely wasn't.
diondokter
commented
Jan 22, 2025
|
|
||
| - Add TX continuation (into RX state) for fast tx-rx turnaround time | ||
| - Add auto ack functionality | ||
| - Add support for 'raw' messages (aka it's up to the user to encode them as valid ieee 802.15.4 frames) |
Contributor
Author
There was a problem hiding this comment.
We forgot to add this in the last PR, so added it here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For fast turnaround times we need some hardware acceleration support.
This PR introduces continuation after TX so the radio can go to RX mode immediately after it is done with transmission.
I've chosen to not incorporate this into the typestate mechanism because all the combination of options would explode the number of variants. After the TX is done, the user needs to call the appropriate continuation function or get a runtime error.
The auto acks are simpler and are pretty much just turned on and off.