Skip to content

Fix undefined on formula toolbar selection #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThibautSF wants to merge 18 commits into
base: formulajs-range-selection
Choose a base branch
from
Open

Fix undefined on formula toolbar selection #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
26b1a31
fix alphabet indexAt and stringAt
Jun 2, 2020
00da1e6
delete weird input element in selector
Jun 2, 2020
0b918b8
better disable editing
Jun 2, 2020
274b7e6
Improve formula editing process within cells
Jun 2, 2020
29dd9b7
add round
Jun 5, 2020
fc3d1bc
Make 'npm run test' command cross-platform
Sep 10, 2020
cc90efd
Enable locale fallback if translation is missing
Sep 9, 2020
02138ad
Allow translation message keys containing '.'
Sep 9, 2020
a3c0712
Include locale.js in lcov reporting
Sep 28, 2020
a67d36d
Create initial test suite for locale.js
Sep 28, 2020
ecef151
Compute all formulas using formula.js
Sep 4, 2020
366c401
Update locale keys with formulajs function names
Sep 9, 2020
c7b348e
Support absolute cell references
Sep 5, 2020
15e6803
Enable click-drag cell range select in formulas
Sep 6, 2020
672a7a6
Improve test coverage of alphabet.js
Sep 28, 2020
11f6e1f
Add morph and translate methods to CellRange
Sep 9, 2020
b70c5f9
Handle SHIFT key when moving cell reference range
Sep 9, 2020
a462f82
Fix undefined on formula toolbar selection
Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"nyc": {
"all": true,
"include": [
"src/core/*.js"
"src/core/*.js",
"src/locale/locale.js"
],
"exclude": [
"**/*.spec.js"
Expand All @@ -29,7 +30,7 @@
"build": "webpack --config build/webpack.prod.js",
"build-locale": "webpack --config build/webpack.locale.js",
"lint": "./node_modules/eslint/bin/eslint.js src",
"test": "nyc ./node_modules/mocha/bin/mocha --require @babel/register test/*",
"test": "nyc ./node_modules/mocha/bin/mocha --require @babel/register --recursive test",
"coverage": "nyc report --reporter=text-lcov > coverage.lcov && codecov -t 31ecdb12-8ecb-46f7-a486-65c2516307dd",
"postinstall": "opencollective-postinstall"
},
Expand Down Expand Up @@ -64,6 +65,7 @@
"webpack-merge": "^4.1.4"
},
"dependencies": {
"hot-formula-parser": "^3.0.2",
"opencollective": "^1.0.3",
"opencollective-postinstall": "^2.0.2"
},
Expand Down
39 changes: 0 additions & 39 deletions src/algorithm/expression.js
View file
Open in desktop

This file was deleted.

7 changes: 4 additions & 3 deletions src/component/dropdown_formula.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
import Dropdown from './dropdown';
import Icon from './icon';
import { h } from './element';
import { baseFormulas } from '../core/formula';
import { cssPrefix } from '../config';

import { SUPPORTED_FORMULAS } from 'hot-formula-parser';

export default class DropdownFormula extends Dropdown {
constructor() {
const nformulas = baseFormulas.map(it => h('div', `${cssPrefix}-item`)
const nformulas = SUPPORTED_FORMULAS.map(it => h('div', `${cssPrefix}-item`)
.on('click', () => {
this.hide();
this.change(it);
})
.child(it.key));
.child(it));
super(new Icon('formula'), '180px', true, 'bottom-left', ...nformulas);
}
}
Loading