Make clicking on an empty point work better in viewing+problem mode#4
Open
kadoban wants to merge 2 commits intojkk:masterfrom
kadoban:master
Open
Make clicking on an empty point work better in viewing+problem mode#4kadoban wants to merge 2 commits intojkk:masterfrom kadoban:master
kadoban wants to merge 2 commits intojkk:masterfrom
kadoban:master
Conversation
this gives the same behavior in that regard as problemMode, clicking on empty locations won't search for moves there in the entire game tree, just from the current cursor location
|
2 years!! Good PR, please merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think that in problems it makes sense to search from the game root, through the entire game tree, for moves when you click an empty space. This just disables that (only for problem mode).
Also adds a setting for just view mode to get rid of the same behavior (default behavior unchanged).