Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
extract_read_features_from_bamin line with otherbam_functionsutilities by supporting both a Python (pysam) and CLI (samtools) backend.Description
extract_read_features_from_bam(bam_file_path: str | Path, samtools_backend: str | None = "auto") -> Dict[str, List[float]]and added type hints and a docstring._require_pysam()that reads viapysam.AlignmentFileand computes median base quality, mapped length viaget_blocks(), and reference lengths frombam_file.references/lengths.samtools view -Hfor@SQlengths and streamssamtools view -F 4output, computing mapped length from CIGAR strings and converting ASCII qualities to Phred scores.pythonandclibackend paths intests/unit/informatics/test_tool_backends.pyto cover the new behavior.Testing
test_extract_read_features_from_bam_python_backendandtest_extract_read_features_from_bam_cli_backendto cover both backends; these tests were committed with the change.pytest tests/unit/informatics/test_tool_backends.py -qwhich failed during test collection withimportlib.metadata.PackageNotFoundError: No package metadata was found for smftools, so automated test execution in this environment did not complete successfully.pysam/subprocesscalls; they can be executed locally or in CI once the package is installable in the test environment (e.g.pip install -e .before runningpytest).Codex Task