Revert struct field reordering in config types#721
Closed
Copilot wants to merge 1 commit intoconfig-selectorfrom
Closed
Revert struct field reordering in config types#721Copilot wants to merge 1 commit intoconfig-selectorfrom
Copilot wants to merge 1 commit intoconfig-selectorfrom
Conversation
3 tasks
Copilot
AI
changed the title
[WIP] Add user profile selector feature for client configuration
Revert struct field reordering in config types
Jan 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## config-selector #721 +/- ##
===================================================
+ Coverage 84.42% 84.48% +0.05%
===================================================
Files 59 59
Lines 3602 3602
===================================================
+ Hits 3041 3043 +2
+ Misses 389 388 -1
+ Partials 172 171 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review on PR #707 identified unintended struct field reordering in
internal/config/types.gothat could affect reflection-based operations and struct initialization without field names.Changes:
Configstruct field order:OpenVPNbeforeOAuth2OpenVPNstruct field order:ClientConfigbeforeBypassThese changes revert the field positions to their original ordering while preserving all functionality added in the profile selector feature.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.