Skip to content

Comments

Revert struct field reordering in config types#721

Closed
Copilot wants to merge 1 commit intoconfig-selectorfrom
copilot/sub-pr-707
Closed

Revert struct field reordering in config types#721
Copilot wants to merge 1 commit intoconfig-selectorfrom
copilot/sub-pr-707

Conversation

Copy link
Contributor

Copilot AI commented Jan 15, 2026

The review on PR #707 identified unintended struct field reordering in internal/config/types.go that could affect reflection-based operations and struct initialization without field names.

Changes:

  • Restored Config struct field order: OpenVPN before OAuth2
  • Restored OpenVPN struct field order: ClientConfig before Bypass

These changes revert the field positions to their original ordering while preserving all functionality added in the profile selector feature.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Add user profile selector feature for client configuration Revert struct field reordering in config types Jan 15, 2026
Copilot AI requested a review from jkroepke January 15, 2026 23:27
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.48%. Comparing base (b3d3386) to head (59f8960).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           config-selector     #721      +/-   ##
===================================================
+ Coverage            84.42%   84.48%   +0.05%     
===================================================
  Files                   59       59              
  Lines                 3602     3602              
===================================================
+ Hits                  3041     3043       +2     
+ Misses                 389      388       -1     
+ Partials               172      171       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkroepke jkroepke closed this Jan 16, 2026
@jkroepke jkroepke deleted the copilot/sub-pr-707 branch February 22, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants