add PROJECT_NAME to environmental variables as an option#122
Open
bmicks wants to merge 1 commit intojkrup:masterfrom
bmicks:addProjectName
Open
add PROJECT_NAME to environmental variables as an option#122bmicks wants to merge 1 commit intojkrup:masterfrom bmicks:addProjectName
bmicks wants to merge 1 commit intojkrup:masterfrom
bmicks:addProjectName
Conversation
Author
|
@jkrup This is also a bit of a test for my next project: to pass additional options like now.features.cloud So, let me know if this initial pull request works for you (and if I did everything correctly) |
jkrup
reviewed
Aug 23, 2018
|
|
||
| export const getProjectName = async () => { | ||
| const environmentVariables = await getEnvironmentVariables(); | ||
| return getEnvironmentVariable('PROJECT_NAME', environmentVariables) |
Owner
There was a problem hiding this comment.
missing semicolon ; here (you can run npm run lint to catch this stuff easily)
jkrup
requested changes
Aug 23, 2018
Owner
jkrup
left a comment
jkrup
left a comment
There was a problem hiding this comment.
Looks good! Thanks so much for the contribution. There's just that one linter error.
Also, before merging, we'll want to edit the README.md to include information about this new flag. I can probably get to that later this week, but if you'd like to do that as well that'd be fantastic.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jkrup I've added some code that I need to change the project name in the env variables. Please let me know if this is something that works for you. Thanks. B