Update MyPy settings (sigstore#1322)

* Enable MyPy strict mode

MyPy is best with strict or nearly strict configuration. Alternatively, set `strict = false`.

Signed-off-by: Dimitri Papadopoulos <[email protected]>

* Remove deprecated `show_error_codes` from MyPy config

Since MyPy v0.990, `show_error_codes = true` the default.

Signed-off-by: Dimitri Papadopoulos <[email protected]>

* Enable `ignore-without-code` in MyPy config

This will force all skips to include the error code, which makes them
more readable, and avoids skipping something unintended.

Signed-off-by: Dimitri Papadopoulos <[email protected]>

* Enable `redundant-expr` in MyPy config

This helps catch useless lines of code, like checking the same condition twice.

Signed-off-by: Dimitri Papadopoulos <[email protected]>

* Enable `truthy-bool` in MyPy config

This catches mistakes in using a value as truthy if it cannot be falsy.

Signed-off-by: Dimitri Papadopoulos <[email protected]>

* Fix MyPy [type-arg] error

Missing type parameters for generic type "dict".

Signed-off-by: Dimitri Papadopoulos <[email protected]>

* Fix MyPy [attr-defined] error

Module "tuf.ngclient" does not explicitly export attributes.

Signed-off-by: Dimitri Papadopoulos <[email protected]>

---------

Signed-off-by: Dimitri Papadopoulos <[email protected]>

Author: DimitriPapadopoulos

pyproject.toml

@@ -104,10 +104,11 @@ allow_redefinition = true
 check_untyped_defs = true
 disallow_incomplete_defs = true
 disallow_untyped_defs = true
+enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]
 ignore_missing_imports = true
 no_implicit_optional = true
-show_error_codes = true
 sqlite_cache = true
+strict = true
 strict_equality = true
 warn_no_return = true
 warn_redundant_casts = true

sigstore/_internal/rekor/client.py

@@ -47,7 +47,7 @@ class RekorLogInfo:
     tree_size: int
     signed_tree_head: str
     tree_id: str
-    raw_data: dict
+    raw_data: dict[str, Any]
 
     @classmethod
     def from_response(cls, dict_: dict[str, Any]) -> RekorLogInfo:

sigstore/_internal/tuf.py

@@ -25,7 +25,7 @@
 
 import platformdirs
 from tuf.api import exceptions as TUFExceptions
-from tuf.ngclient import Updater, UpdaterConfig
+from tuf.ngclient import Updater, UpdaterConfig  # type: ignore[attr-defined]
 
 from sigstore import __version__
 from sigstore._utils import read_embedded