Support minified JSON output #279
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the output from cgltf is unminified and formatted. This is great for inspecting and debugging the output, but it'd also be nice to have minified JSON when not debugging.
In my testing, this can trim off a few KB. In practice, this lets me run a little snippet I made to view beautified GLB JSON that I couldn't use before:
What I chose to do in this PR is add a
CGLTF_MINIFYoption along with some other macros that get redefined when minifying. This required using find-and-replace to change, so there's a chance I missed a spot.When I tested without defining the macro (default), my test GLB is byte-per-byte same as before. Then when enabling the new macro I can't find any remaining unminified JSON.
Let me know if there's improvements to make, or if this affects maintainability and whatnot. Thanks.