Skip to content

discriminate nginx and direct requests#12

Open
sjanssen2 wants to merge 37 commits intodevfrom
tornado_FetchFileFromCentralHandler
Open

discriminate nginx and direct requests#12
sjanssen2 wants to merge 37 commits intodevfrom
tornado_FetchFileFromCentralHandler

Conversation

@sjanssen2
Copy link
Member

@sjanssen2 sjanssen2 commented Sep 17, 2025

and either use nginx or tornado file delivery method respectively

I've also added the ability to fetch whole directories from Qiita main. As malicious clients could thus get the WHOLE content of base_data_dir, only directories can be fetched, which are a) listed as "directory" filetypes in Qiita's DB and b) where client provided a valid mountpoint

When Qiita is in testmode, files/dirs can now also be deleted trough an API endpoint, which is not exposed in productive mode.

@coveralls
Copy link

coveralls commented Sep 17, 2025

Pull Request Test Coverage Report for Build 19363549474

Details

  • 182 of 249 (73.09%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 91.943%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiita_pet/handlers/cloud_handlers/tests/test_file_transfer_handlers.py 151 156 96.79%
qiita_pet/handlers/cloud_handlers/file_transfer_handlers.py 28 90 31.11%
Files with Coverage Reduction New Missed Lines %
qiita_pet/handlers/cloud_handlers/file_transfer_handlers.py 3 32.33%
Totals Coverage Status
Change from base Build 17326449280: -0.2%
Covered Lines: 25175
Relevant Lines: 27381

💛 - Coveralls

sjanssen2 and others added 27 commits September 18, 2025 11:23
… to avoid lazy client from downloading whole BASE_DATA_DIR
…alsoDirs

Tornado fetch file from central handler also dirs
…alsoDirs_debug

Tornado fetch file from central handler also dirs debug
…delete

add ability to delete files/dirs through API, but only in qiita test …
* general fixes 11-2025

* fix TestWorkflowHandler
* allow multiple standalone steps in workflows

* flake8

* adding a test

* 2 commands from start & extra commands

* more tests

* artifact.parents
* download public prep data

* addressing @lucaspatel comments
* TST: study associations endpoint test

* MAINT: be defensive on artifact prep assocation expectations

* API: add /api/v1/study/<id>/associations to retrieve comprehensive id, path, processing information for a study

* DOC: note schema, add some additiona doc strings and comments

* LINT: pass w/ ruff check

* LINT: now with flake8

* Rollback: allow an artifact to be unlinked

* DOC: note internal rest endpoint

* LINT: flake8

* Remove extraneous sort

* An incomplete prep will not have an artifact
antgonza and others added 8 commits December 2, 2025 14:54
* add parents ArtifactHandler

* fixing test

* add job_id to ArtifactAPItestHandler

* flake8
* flake8 to ruff

* . import

* check_analysis_access
* add analysis id to validate parameters

* adding artifacts to job creation

* add analysis to release

* mv up pvals

* artifacs -> artifacts

* rm counts

* rewrite scenarios

* fix analysis error

* no prep_template, parents or analysis provided

* data_type

* rm parents

* params=None

* overwrite_lock
* TST: study associations endpoint test

* API: add /api/v1/study/<id>/associations to retrieve comprehensive id, path, processing information for a study

* SQL: draft schema changes to support additional identifiers

* API: unique_ids stub on base metadata object

* TST: check unique_ids

* TST: check unique_ids

* API: passing SampleTemplate.unique_ids

* API: passing PrepTemplate.unique_ids

* API: passing Artifact.unique_ids

* Constrain returned values

* Based relative to Qiita schema

* lint

* Quality to schema
* 2026.01

* Apply suggestions from code review

Co-authored-by: Amanda Birmingham <AmandaBirmingham@users.noreply.github.com>

* rm å [skip ci]

---------

Co-authored-by: Amanda Birmingham <AmandaBirmingham@users.noreply.github.com>
Corrected the spelling of 'January' and updated the description of new commands in 'qp-pacbio'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants