Skip to content

Fix an invalid read.#282

Merged
jlblancoc merged 1 commit intojlblancoc:masterfrom
drwells:fix-invalid-read
Dec 26, 2025
Merged

Fix an invalid read.#282
jlblancoc merged 1 commit intojlblancoc:masterfrom
drwells:fix-invalid-read

Conversation

@drwells
Copy link
Contributor

@drwells drwells commented Dec 24, 2025

If num_results == 0 then dynamic_idx is empty, so dynamic_idx[0] does not exist. I caught this by building nanoflann with -D_GLIBCXX_ASSERTIONS.

If num_results == 0 then dynamic_idx is empty, so dynamic_idx[0] does
not exist.
@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.85%. Comparing base (92911c0) to head (beb32c4).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files           1        1           
  Lines         675      675           
  Branches      127      127           
=======================================
  Hits          566      566           
  Misses        109      109           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlblancoc jlblancoc merged commit ba47cfc into jlblancoc:master Dec 26, 2025
9 checks passed
@jlblancoc
Copy link
Owner

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants