Alternative Lahman DB route #435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanCooke
reviewed
Jul 30, 2025
| url = "https://github.com/chadwickbureau/baseballdatabank/archive/master.zip" | ||
| base_string = "baseballdatabank-master" | ||
| url = "https://github.com/jmaslek/LahmanDatabase/archive/refs/heads/main/baseballdb.zip" | ||
| base_string = "LahmanDatabase-main/baseballdb" |
There was a problem hiding this comment.
@jmaslek I didn't see a LahmanDatabase-main/baseballdb in your github archive at https://github.com/jmaslek/LahmanDatabase/archive/refs/heads/main/baseballdb.zip
However, I did see a LahmanDatabase-main/unzipped directory there. Should the base_string be "LahmanDatabase-main/unzipped" instead?
Suggested change
| base_string = "LahmanDatabase-main/baseballdb" | |
| base_string = "LahmanDatabase-main/unzipped" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this comment: #434 (comment)
I just threw the files onto my own repo (can be easily adjusted to be on pybaseball, I jwould just rather it be added so we can point the link at main instead of this branch).
There is one manually maintained file (teams_upstream) that I do not know anything about.