Fixed data element not valid for a particular endpoint#860
Open
lc-excell wants to merge 1 commit intojlevers:mainfrom
Open
Fixed data element not valid for a particular endpoint#860lc-excell wants to merge 1 commit intojlevers:mainfrom
lc-excell wants to merge 1 commit intojlevers:mainfrom
Conversation
Owner
|
Thanks for the PR! Would you be open to adding a test for this? |
Owner
|
Hey @lc-excell – just checking in on this again. If you'll have a chance to write some tests soon, I'll wait to cut a new release till this PR is merged, but if not I'm going to make a new release sooner. No pressure either way :) |
|
Any update on this? I'm having to run a patch at the point of installation to be able to use the library for getOrders calls |
Owner
|
@joekersh I never heard back from @lc-excell about the tests. If you want to take this on and write some tests, I'd be happy to merge and release. Just haven't had the chance to deal with it myself, and I haven't heard many people complaining about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#859