Use the project's full display name in the message#61
Open
groves wants to merge 1 commit intojlewallen:masterfrom
Open
Use the project's full display name in the message#61groves wants to merge 1 commit intojlewallen:masterfrom
groves wants to merge 1 commit intojlewallen:masterfrom
Conversation
Previously it was using display name. The difference is for projects nested in folders. getDisplayName returns the last segment there, whereas getFullDisplayName includes all the parent folders as well, separated by ». For projects not in folders, they're identical. We have several builds with the same final segment name that are only different based on the folder they're in. This works much better for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was using display name. The difference is for projects
nested in folders. getDisplayName returns the last segment there,
whereas getFullDisplayName includes all the parent folders as well,
separated by ». For projects not in folders, they're identical.
We have several builds with the same final segment name
that are only different based on the folder they're in. This works much
better for that.