fix: Clear auto-suggestion menu list when no completions match#1631
Merged
fix: Clear auto-suggestion menu list when no completions match#1631
Conversation
When AUTO_MENU_LIST and autosuggestion are enabled, the completion menu stayed visible even after the user typed characters that eliminated all matching candidates. The root cause was in clearChoices(), which called doList() with an empty candidate list. Since doList() returns early at the possibleSize == 0 check without clearing the post field, the stale completion menu lambda remained set and continued to render the old candidates on every redisplay. Fix clearChoices() to directly set post = null instead of delegating to doList(), which correctly removes the completion display when there are no matching candidates. Fixes #1338
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clearChoices()thenlistChoices(true)on every keystroke.clearChoices()calleddoList(emptyList, ...), butdoList()returns early at thepossibleSize == 0check (line 5184) without clearing thepostfield. The stalepostlambda from the previous completion continued to render old candidateslistChoices(true)subsequently finds no matches, it also returns early without touchingpostclearChoices()now directly setspost = nullinstead of delegating todoList()with an empty listTest plan
AUTO_MENU_LIST+SuggestionType.COMPLETER, type a prefix that matches completions, then type characters that eliminate all matches — verify the menu disappears