Draft
Conversation
Collaborator
|
let me push me 1.21.8 branch so you can base it off of that, i think i've worked around most if not all of the problems you're seeing here (assuming that .11 didn't break them again) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remaining problems:
instances of
renderItemwhere they changed the method's arguments so much (and removed all usages of the method in the minecraft codbase so I have nothing to base new code off of) are broken:org/jlortiz/playercollars/client/CollarRenderer.javaorg/jlortiz/playercollars/client/FootPawRenderer.javaorg/jlortiz/playercollars/client/PawRenderer.javaorg/jlortiz/playercollars/client/screen/TagLikeListWidget.javahas inner classesTransparentButtonandTagEntrythat I have no clue how they work or how to fixsrc/main/java/org/jlortiz/playercollars/client/CollarRenderer.javausedgetArmorItemswhich seemingly has no equivalent anymore.org/jlortiz/playercollars/datagen/DatagenEntrypoint.javausedgetOrCreateTagBuilderwhich I havent bothered looking for migration guides for yetorg/jlortiz/playercollars/datagen/ModelDataGenerator.javaused a lot of interesting looking stuff that I don't understand and cant figure out how to migrate ingenerateBlockStateModelsThese are stopping me from getting a build running and testing out the mod