General model/texture improvements by testerpester2 · Pull Request #87 · jlortiz0/PlayerCollars

testerpester2 · 2026-01-09T02:35:29Z

Models

Changed:

Collar shape
Tagless collar shape
Paws don't have a hole in them anymore since you'll basically never see it
Dog bowl to use brown concrete powder instead of compost
Removed pivot points and changed arrows height to 1 instead of 0.99 in invisible fence model

Updated:

Invisible fence hand model to have a better UV

Textures

Changed:

Detailed collar tag_overlay (by testerPester)
Remade deeds so they no longer have mixels
Spatula is no longer based on programmer art

Added:

Separate inventory textures for paws, foot paws, collars, tagless collars, clickers, and invisible fences
Custom texture for invisible fence hand model

All the textures except for the tag_overlay were made by MiffenKop!!!

- Clickers now have more detail and aren't huge - Collars now have custom inventory texture (will make it show up correctly in-game in the next commit) - collar_locker.png is now 16x - Deed of Ownerships now no longer have mixels and has been made to look more like paper, plus is now 16x - Golden Spatula now looks more inline with the other golden tools - Paws now have custom inventory texture (will make it show up correctly in-game in the next commit)

…lars into fabric-1.21.4

src/main/java/org/jlortiz/playercollars/datagen/ModelDataGenerator.java

src/main/resources/assets/playercollars/models/item/collar.json

src/main/resources/assets/playercollars/models/item/invisible_fence.json

sorgyfrog · 2026-01-11T12:50:39Z

src/main/resources/assets/playercollars/textures/item/clicker_overlay.png

is the speaker grill strip supposed to always be white? also, the sides of the button being light-colored can look strange if the clicker is dyed a dark color.

Clickers don't have speakers.... the clicker is based off of this image, and yeah that's fair, at the time I made the texture I forgot it could be dyed so I'll back sure to fix that

sorgyfrog · 2026-01-11T12:52:05Z

src/main/resources/assets/playercollars/items/collar.json

-      {
-        "type": "minecraft:map_color",
-        "default": 3361970
+        "when": "gui",


just gui means the 3d model is also used when the item is held in the hand. is that intentional, or did you only want it to use a 3d model on the head?

src/main/java/org/jlortiz/playercollars/datagen/ModelDataGenerator.java

sorgyfrog · 2026-01-11T13:10:00Z

src/main/resources/assets/playercollars/textures/item/invisible_fence.png

this doesn't really represent the item. i prefer the 3d glass model.

I can agree on this, it was Testers idea and I just made it look better

It's updated to better match the 3D model now

src/main/resources/assets/playercollars/textures/item/dog_bowl.png

src/main/resources/assets/playercollars/textures/item/collar_base.png

sorgyfrog · 2026-01-11T13:12:23Z

src/main/resources/assets/playercollars/textures/item/collar_tag_inner.png

kinda difficult to tell what this is supposed to be at this resolution

It's ment to be the paw, at this resolution was removed due to it looking weird when bigger

Co-authored-by: sorgyfrog <203951971+sorgyfrog@users.noreply.github.com>

testerpester2 · 2026-01-20T22:50:22Z

I didn't mean to to request review honestly I didn't know what it did I'm not super versed in Github stuff still

sorgyfrog · 2026-01-21T08:44:22Z

i'll unrequest myself for now, since there seems to be some feedback not addressed. add me for review again or ping me when you're ready.

MiffenKop · 2026-01-25T03:14:37Z

i'll unrequest myself for now, since there seems to be some feedback not addressed. add me for review again or ping me when you're ready.

Tester has been problems with generated model stuff so she kinda slowed down alittle

Jakubman625 · 2026-02-06T19:39:46Z

I tried this look and honestly... I really don't like the 3D model of the Paws... It doesn't look good. I prefer the old design as it looks really nice and fits the pet. I like the texture of the paws in the inventory tho! As for the Collar, that is a nice touch, seems fine. For the dog bowl, the food looks stunning! It really looks like a dog food, which is amazing and would really advice to have that in the mod! For the collar, if the mod would get Bell Collars, it could be a really confusing texture as it kinda looks like a Bell Collar. Spatula is fine, the Deed... I agree with Sorgyfrog. Their texture looks better. As for the Clicker, I suppose that looks fine, more realistic. Overall, There are things I like and things I don't like. But Good Job! :)

testerpester2 and others added 23 commits December 2, 2025 19:44

Did some basic model adjustments

9b1ac07

Clicker and Paws

df293d5

Merge upstream textures

68b1da1

Merge branch 'jlortiz0:fabric-1.21.4' into fabric-1.21.4

7f190dc

I figured out item jsons yayy

b3a3829

Why was this here I don't even use it

d7159e0

I dunno how to do datagen

a05648c

Updated Clicker so the button doesn't get coloured

57775ca

inventory texture for Invisible fence

36a882e

clicker fix

2ef4e61

2D fence item thingy

aed9d84

Duplicate fix

37036a0

Update invisible_fence.json

f076f89

Moved inventory textures for collar by one pixel

5f0efa6

Added testerPester and MiffenKop to contributors cause I forgot

4c40803

the lowercase m is crazy /silly

a4b017f

Conflict resolve stuff

25ce083

Merge branch 'fabric-1.21.4' of https://github.com/jlortiz0/PlayerCol…

b2ee0f3

…lars into fabric-1.21.4

Duplicates blow up please

f9f2d3d

Invisible Fence hand model now has better textures

b23df80

Update invisible_fence.json

f59a7fd

Got rid of some more generation stuff that keeps preventing builds

44664b4

sorgyfrog requested changes Jan 11, 2026

View reviewed changes

testerpester2 and others added 2 commits January 13, 2026 22:17

Datagen thingy wowzers thanks

7b2fb20

Co-authored-by: sorgyfrog <203951971+sorgyfrog@users.noreply.github.com>

Suggested changes

864b532

testerpester2 requested a review from sorgyfrog January 20, 2026 22:49

Remade Invisible Fence Inventory texture to match 3d model

f07960f

sorgyfrog removed their request for review January 21, 2026 08:44

testerpester2 added 3 commits January 22, 2026 09:58

Datagen finally fixed and does paws

8503138

I forgot the invisible fence item whoops

36bcceb

Restore missing collar models

06a6106

Readded foot paws cause I forgot

3f04c75

Conversation

testerpester2 commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Models

Textures

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

testerpester2 commented Jan 20, 2026

Uh oh!

sorgyfrog commented Jan 21, 2026

Uh oh!

MiffenKop commented Jan 25, 2026

Uh oh!

Jakubman625 commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

testerpester2 commented Jan 9, 2026 •

edited

Loading