Skip to content

Remove arch indication for Darwin. Partially fixes #53#60

Open
dabaer wants to merge 1 commit intojlouis:masterfrom
dabaer:patch-1
Open

Remove arch indication for Darwin. Partially fixes #53#60
dabaer wants to merge 1 commit intojlouis:masterfrom
dabaer:patch-1

Conversation

@dabaer
Copy link

@dabaer dabaer commented Aug 24, 2021

I'm unsure why it's specified since darwin has been uni-arch for ages, but the arm version is smart enough to know which arch to build.

M1 Mac Mini

dabaer@Mac-mini enacl % uname -m
arm64
dabaer@Mac-mini enacl % make compile
rebar3 compile
===> Verifying dependencies...
===> Compiling c_src/aead.c
===> Compiling c_src/enacl.c
===> Compiling c_src/enacl_ext.c
===> Compiling c_src/enacl_nif.c
===> Compiling c_src/generichash.c
===> Compiling c_src/hash.c
===> Compiling c_src/kdf.c
===> Compiling c_src/kx.c
===> Compiling c_src/public.c
===> Compiling c_src/pwhash.c
===> Compiling c_src/randombytes.c
===> Compiling c_src/secret.c
===> Compiling c_src/secretstream.c
===> Compiling c_src/sign.c
===> Linking /Users/jadenn/Documents/arviksa/enacl/priv/enacl_nif.so
===> Analyzing applications...
===> Compiling enacl
dabaer@Mac-mini enacl % make tests
rebar3 ct
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling enacl
===> Running Common Test suites...
%%% enacl_SUITE: ..........
All 10 tests passed.

Intel Mac Mini

Dakoras-Mini:enacl dakora$ uname -m
x86_64
Dakoras-Mini:enacl dakora$ make compile
rebar3 compile
===> Verifying dependencies...
===> Compiling c_src/aead.c
===> Compiling c_src/enacl.c
===> Compiling c_src/enacl_ext.c
===> Compiling c_src/enacl_nif.c
===> Compiling c_src/generichash.c
===> Compiling c_src/hash.c
===> Compiling c_src/kdf.c
===> Compiling c_src/kx.c
===> Compiling c_src/public.c
===> Compiling c_src/pwhash.c
===> Compiling c_src/randombytes.c
===> Compiling c_src/secret.c
===> Compiling c_src/secretstream.c
===> Compiling c_src/sign.c
===> Linking /Users/dakora/enacl/priv/enacl_nif.so
===> Analyzing applications...
===> Compiling enacl
Dakoras-Mini:enacl dakora$ make tests
rebar3 ct
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling enacl
===> Running Common Test suites...
%%% enacl_SUITE: ..........
All 10 tests passed.

I'm unsure why it's specified since darwin has been uni-arch for ages, but the arm version is smart enough to know which arch to build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant