Skip to content

Adds support for marshmallow @post_load #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2019
Merged

Adds support for marshmallow @post_load #119

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7062102
Fixes #103, adds support for `@post_load`:
elatomo Sep 24, 2018
6ec36d3
Use type check instead duck-typing
sloria Jun 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion flask_apispec/wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,11 @@ def call_view(self, *args, **kwargs):
parsed = parser.parse(schema, locations=option['kwargs']['locations'])
if getattr(schema, 'many', False):
args += tuple(parsed)
else:
elif getattr(parsed, 'update', False):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is risk of a false-positive here, e.g. model objects with an update method, so I think type-checking is preferable to duck-typing in this case.

I'll make this change myself.

kwargs.update(parsed)
else:
args += (parsed, )

return self.func(*args, **kwargs)

def marshal_result(self, unpacked, status_code):
Expand Down
24 changes: 23 additions & 1 deletion tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import json

from flask import make_response
from marshmallow import fields, Schema
from marshmallow import fields, Schema, post_load

from flask_apispec.utils import Ref
from flask_apispec.views import MethodResource
Expand All @@ -30,6 +30,28 @@ def view(**kwargs):
res = client.get('/', {'name': 'freddie'})
assert res.json == {'name': 'freddie'}

def test_use_kwargs_schema_with_post_load(self, app, client):
class User:
def __init__(self, name):
self.name = name

class ArgSchema(Schema):
name = fields.Str()

@post_load
def make_object(self, data):
return User(**data)

@app.route('/', methods=('POST', ))
@use_kwargs(ArgSchema())
def view(user):
assert isinstance(user, User)
return {'name': user.name}

data = {'name': 'freddie'}
res = client.post('/', data)
assert res.json == data

def test_use_kwargs_schema_many(self, app, client):
class ArgSchema(Schema):
name = fields.Str()
Expand Down