Skip to content

fix: support string compatible types in to_string #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: support string compatible types in to_string #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30d30ed
fix: support string compatible types in to_string
eddycharly Jun 27, 2024
f74a5c1
Merge branch 'main' into cmp
eddycharly Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pkg/api/api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,22 @@ func TestSearch(t *testing.T) {
}},
},
want: 1.0,
}, {
args: args{
expression: "length(@[?to_string(metric.__name__) == 'foo'])",
data: []struct {
Metric map[Label]Label
}{{
Metric: map[Label]Label{
"__name__": "foo",
},
}, {
Metric: map[Label]Label{
"__name__": "bar",
},
}},
},
want: 1.0,
}, {
args: args{
expression: "length(@[?metric.__name__ == 'foo'])",
Expand Down
5 changes: 5 additions & 0 deletions pkg/functions/functions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ const (
JpAny JpType = "any"
)

var stringType = reflect.TypeFor[string]()

type FunctionEntry struct {
Name string
Arguments []ArgSpec
Expand Down Expand Up @@ -695,6 +697,9 @@ func jpfToString(arguments []interface{}) (interface{}, error) {
if v, ok := arguments[0].(string); ok {
return v, nil
}
if argType := reflect.TypeOf(arguments[0]); argType.Kind() == stringType.Kind() {
return reflect.ValueOf(arguments[0]).Convert(stringType).Interface(), nil
}
result, err := json.Marshal(arguments[0])
if err != nil {
return nil, err
Expand Down