Skip to content

Conversation

@TorbenMerrald
Copy link

I have created danish messagefiles and translated them. Thanks.

Copy link
Contributor

@knstvk knstvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Torben,
Thank you very much for your contribution!

Are you sure we need the country code in the file names? Can we make it simpler with just da locale?

Also, please update your fork and fix the conflict in build.gradle, it's been changed recently.

@TorbenMerrald
Copy link
Author

Of course - Hope that it is now ok

Copy link
Contributor

@knstvk knstvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing.
Perhaps some files have non-UTF-8 encoding, so the messages are incorrect in UTF-8, for example:
image

The same is in UI:
image

Please make sure all property files are in UTF-8. Set this in your IDE:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants