Stabilise surefire #327
Merged
Stabilise surefire #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ven.plugins-maven-gpg-plugin-3.2.0' into gpg-check
This change adds a new build trigger to the `.github/workflows/build.yml` file. The build will now be triggered for any push to a branch that matches the `wip/**` pattern. This allows for continuous integration on work-in-progress branches. Additionally, a check has been added to the build process to prevent pull requests from `wip/**` branches from being merged into `master`. This is a safeguard to prevent accidental merges of unfinished work.
This change introduces two main improvements: 1. A new build trigger for `wip/**` branches in the `.github/workflows/build.yml` file. This allows for continuous integration on work-in-progress branches. A merge guard has also been added to prevent these branches from being accidentally merged into `master`. 2. A fix for the build failure on Java 17. The `pom.xml` has been modified to include a Maven profile that is activated on Java 9 and newer. This profile adds the `--add-opens=java.base/java.lang=ALL-UNNAMED` flag to the test execution, which is required for the tests to run successfully on modern Java versions. This change is backward-compatible and does not affect the builds on Java 8 and 11.
This change introduces two main improvements: 1. A new build trigger for `wip/**` branches in the `.github/workflows/build.yml` file. This allows for continuous integration on work-in-progress branches. A merge guard has also been added to prevent these branches from being accidentally merged into `master`. 2. A fix for the build failure on Java 17. The `pom.xml` has been modified to include a Maven profile that is activated on Java 9 and newer. This profile adds the `--add-opens=java.base/java.lang=ALL-UNNAMED` and `--add-opens=java.base/java.io=ALL-UNNAMED` flags to the test execution, which are required for the tests to run successfully on modern Java versions. This change is backward-compatible and does not affect the builds on Java 8 and 11. The `argLine` in the `pom.xml` has been split over multiple lines for better readability as requested.
This change introduces two main improvements:
1. A new build trigger for `wip/**` branches in the `.github/workflows/build.yml` file. This allows for continuous integration on work-in-progress branches. A merge guard has also been added to prevent these branches from being accidentally merged into `master`.
2. A fix for the build failures on Java 17. The `pom.xml` has been modified to:
- Upgrade the `asm.version` to `9.6` to support Java 17 class files.
- Include a Maven profile that is activated on Java 9 and newer. This profile adds the `--add-opens=java.base/java.lang=ALL-UNNAMED` and `--add-opens=java.base/java.io=ALL-UNNAMED` flags to the test execution, which are required for the tests to run successfully on modern Java versions. This change is backward-compatible and does not affect the builds on Java 8 and 11.
The `argLine` in the `pom.xml` has been split over multiple lines for better readability as requested.
Add build trigger for wip branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.