Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the --version flag functionality in osctrl-admin by adding proper version handling and build metadata. The changes ensure that when users run osctrl-admin --version or osctrl-admin -v, the application prints version information and exits instead of starting the full service.
- Adds build-time metadata variables for version, commit, and date information
- Implements custom version printer and flag handling similar to other services
- Restructures application flow to prevent service initialization for version/help commands
- Updates build configuration to include version metadata in compiled binaries
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/admin/main.go | Adds version metadata variables, custom version printer, and restructures main flow to handle version flag properly |
| cmd/tls/main.go | Removes unnecessary blank lines for consistency |
| Makefile | Updates admin build targets to include build arguments with version metadata |
| .goreleaser.yml | Updates ldflags to use correct variable names for build metadata injection |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Using `buildVersion` to keep consistency Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for
osctrl-adminto print out the version and exit when issuing the-v,--versionflag. Also adding metadata to build.